Made GeometricDet thread-safe

[Dr15Jones]

GeometricDet::setGeographicalID is now non-const. To allow children
of a GeometricDet to have their geomgraphicalID set we added a
component(size_t) method which gives non-const access to a child.
All classes which were modifying the GeometricDet have been updated
to support the new interface.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made GeometricDet thread-safe

It involves the following packages:

Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

@slava77 @anton-a Could you run a test to be sure I didn't botch the change?

[slava77]

Hi Chris,

I don't see problems on the code side, at least at a quick glance.
There should be enough phase space probed by the jenkins tests to uncover a problem if there is one.
So, I'd just wait for jenkins and look at the comparisons with the baseline there.

[Dr15Jones]

Thanks for taking a look.

[Dr15Jones]

+1
Assuming Jenkin's is happy

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2799/430/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[slava77]

@nclopezo Hi David, could you check if the jenkins comparisons with the baseline would complete.
How long does it usually take?
May I suggest to send a +1 from the cmsbuild jenkins tests only after the comparisons with the baseline are actually available.

Thank you

[nclopezo]

@slava77
Hi Slava,
For this pull request they are already there.
The comparison creates the base files just after the IB is installed, and when there are issues with the IBs workflow, they are not created. So sometimes I have to check and manually restart the comparisons. I can talk to Giulio about the +1.