New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM/Info: fix offline DCS bit summary #28002
Conversation
... using DQMIO files from DAS. This could also be used to privately re-harvest runs, but it does not properly emulate T0/Computing-run harvesting.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28002/11906
|
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: DQM/EcalMonitorClient @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
for what I can test the added scripts look functional |
+1 |
PR description:
This PR attempts to fix the DCS status plot at
Info/EventInfo/reportSummaryMap
. Since the harvesting semantic changes from #26232 this plot was showing incorrect values, depending on the order that LS where processed in.The fix is a simple additional
Reset
call to restore the old semantics. However, there are more problems with this module: ThePhysics Declared
row seems to not work correctly since a long time, and shows more arbitrary fluctuations with this change. Also, it is not clear if this code will work without the SCAL FED.Therefore, in the longer term, we should drop this module and replace it with the logically much simpler online version. That, however, might require additional changes to the render plugins in DQMGUI.
This PR also contains some scripts to help debugging such problems in HARVESTING.
PR validation:
In the
runTheMatrix
workflows no changes are expected, since the problem only appears when more than one lumisecition is processed. This PR contains a test script that re-runs harvesting from production DQMIO data that was used to test this change.if this PR is a backport please specify the original PR:
Not a backport, but we might want a backport for UL rereco.