Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/Info: fix offline DCS bit summary #28002

Merged
merged 6 commits into from Sep 19, 2019

Conversation

schneiml
Copy link
Contributor

PR description:

This PR attempts to fix the DCS status plot at Info/EventInfo/reportSummaryMap. Since the harvesting semantic changes from #26232 this plot was showing incorrect values, depending on the order that LS where processed in.

The fix is a simple additional Reset call to restore the old semantics. However, there are more problems with this module: The Physics Declared row seems to not work correctly since a long time, and shows more arbitrary fluctuations with this change. Also, it is not clear if this code will work without the SCAL FED.

Therefore, in the longer term, we should drop this module and replace it with the logically much simpler online version. That, however, might require additional changes to the render plugins in DQMGUI.

This PR also contains some scripts to help debugging such problems in HARVESTING.

PR validation:

In the runTheMatrix workflows no changes are expected, since the problem only appears when more than one lumisecition is processed. This PR contains a test script that re-runs harvesting from production DQMIO data that was used to test this change.

if this PR is a backport please specify the original PR:

Not a backport, but we might want a backport for UL rereco.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28002/11906

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQM/EcalMonitorClient
DQMServices/Components

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2548/console Started: 2019/09/17 17:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-798299/2548/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957336
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956993
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

for what I can test the added scripts look functional

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 227ea1f into cms-sw:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants