Fixed thread-safety issues with GeometricDetExtra

[Dr15Jones]

The unused method setGeomgraphicalId was const and was used to change
a mutable. By changing the method to non-const we could get rid of the
mutable and solve the thread-safety issue. No other code is affected
by this change.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Fixed thread-safety issues with GeometricDetExtra

It involves the following packages:

Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

+1
Trivial

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2806/442/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

-1
I found an error when building:

                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2014-03-08-1400/src/DataFormats/Common/interface/ProductData.h:11,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2014-03-08-1400/src/DataFormats/Common/interface/BasicHandle.h:28,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2014-03-08-1400/src/FWCore/Framework/interface/Event.h:20,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-08-1400/src/SimTracker/TrackerHitAssociation/test/TestAssociator.h:12,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-08-1400/src/SimTracker/TrackerHitAssociation/test/TestAssociator.cc:11:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2014-03-08-1400/src/FWCore/Utilities/interface/TypeWithDict.h:20:23: fatal error: TDataType.h: No such file or directory
 #include "TDataType.h"
                       ^
compilation terminated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-08-1400/src/SimTracker/SiStripDigitizer/plugins/DigiSimLinkPileUpSignals.cc 
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2014-03-08-1400/src/DataFormats/Provenance/interface/BranchDescription.h:16:0,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2806/446/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[Dr15Jones]

you are building against a too old IB (i.e. 08/03/2014). This pull request is on top of the present head of CMSSW_7_1_X.

[nclopezo]

Ok, I will restart the tests. I was using the latest available IB.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2806/448/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?