New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3: changes needed to fix runTheMatrix errors for PY3 IBs #28078
Conversation
The code-checks are being triggered in jenkins. |
please test workflow 200.0,1370.0 for CMSSW_11_0_PY3_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28078/12039
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: Configuration/Applications @SiewYan, @efeyazgan, @mkirsano, @kpedro88, @cmsbuild, @franzoni, @agrohsje, @alberto-sanchez, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
please test workflow 200.0,1370.0 for CMSSW_11_0_PY3_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28078/12043
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+core |
+operations @smuzaffar the addition of |
Yes, universal_newlines is to get the data in text format. By default it is in binary format. protocol=2 option is needed to generate pickle files in format which python2 can also read it. addOnTest generates a pickle file with summary of results which we upload to cmssdt web server where we have python2. |
@SiewYan, @efeyazgan @qliphy can you please look in to it? This is needed to fix many failing workflows for PY3 IBs. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This change should allow to run most of relvals for Python3 IBs. There are still some errors but those are coming from external packages.