Add RelVals for APV Dynamic Gain Simulation + HIP mitigation

[mmusich]

PR description:

Title says it all, this is a follow-up of PR #28024.
Add for the various no-PU, PU (std. mixing) and PU (premixing) dynamic APV gains simulation relvals the HIP mitigation customization as it is run for the2016 data.
This will allow to have the complete battery of tests needed to perform the validation requested at https://its.cern.ch/jira/projects/PDMVRELVALS/issues/PDMVRELVALS-59

PR validation:

Passes standard runTheMatrix tests:

runTheMatrix.py -l 1325.91,25202.2,250202.4,250202.5 -t 4 -j 8 --ibeos

Preliminary comparisons of the:

• default simulation (25202)
• Dynamic gain APV simulation ON + HIP mitigation OFF (25202.1)
• Dynamic gain APV simulation ON + HIP mitigation ON (25202.2)

have been made, here is a preview of some of the salient effects:

if this PR is a backport please specify the original PR:

This PR is not a backport.
cc:
@pieterdavid @EmyrClement @mtosi @JanFSchulte

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28082/12051

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_pileup.py modified in PR(s): Nano AOD step added for 2016 standard and pileup relvals #28061
  • File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Nano AOD step added for 2016 standard and pileup relvals #28061
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Updating Puppiproducer to include fillDescriptions v2 #28020, Nano AOD step added for 2016 standard and pileup relvals #28061

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu
can test be started here, please?

[kpedro88]

please test workflow 1325.91,25202.2,250202.4,250202.5

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2731/console Started: 2019/09/30 18:22

[cmsbuild]

+1
Tested at: c8bae97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086769/2731/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086769/2731/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-086769/1325.91_TTbar_13+TTbar_13+DIGIUP15APVSimu+RECOUP15_HIPM+HARVESTUP15+ALCATTUP15
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-086769/250202.4_TTbar_13+TTbar_13+DIGIPRMXUP15APVSimu_PU25+RECOPRMXUP15_HIPM_PU25+HARVESTUP15_PU25
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-086769/250202.5_TTbar_13+TTbar_13+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_HIPM_PU25+HARVESTUP15_PU25
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-086769/25202.2_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25_HIPM+HARVESTUP15_PU25

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2958092
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2957750
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[chayanit]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1