Run3-Sim47 Allow saving tracks with momentum above a certain threshold

[bsunanda]

PR description:

These changes allow saving some of the Sim tracks entering in the HGCal region and have kinetic energies above a threshold. By default the thresholds are set high - one need to configure it to allow tracks at lower energies

PR validation:

Tested with cfg files in SimG4CMS/Calo/test/python area and also with the standard run matrix

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28088/12068

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Config files needed to integrate PPS simhits into the cms simulation #27990

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28088/12068/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28088/12068/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28088/12069

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Config files needed to integrate PPS simhits into the cms simulation #27990

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalSimData
Geometry/HcalSimData
SimG4CMS/Calo
SimG4Core/Application

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2717/console Started: 2019/09/29 15:39

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2745/console Started: 2019/10/02 07:38

[cmsbuild]

+1
Tested at: 17316bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de8852/2745/summary.html

[cmsbuild]

Comparison job queued.

[civanch]

@bsunanda , sorry, I do not raise this question before. Is it optimal introduce MCtruth into sensitive detector code? I mean that until now MCtruth was in TrackingAction/StackingAction - it is more natural place, because there is sorting particles at production - we create a new MCtruth object depending on energy of a particle at production. Inside the SD code it is more easy identify the moment when a particle hit HGCal but to handle particles produced inside HGCal user actions are better.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de8852/2745/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2956833
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956491
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[ianna]

+1

[civanch]

+1
let us left this variant and later may be make MC truth in user actions.

[fabiocos]

@kpedro88 I think your remarks have been addressed, and you had already signed this code. Latest changes look straightforward to me, I merge the PR, please check it and comment in case.

[fabiocos]

+1

[fabiocos]

merge

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.