New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cosmics path for HLT validation (110X) #28125
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28125/12168
|
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master. It involves the following packages: HLTrigger/Configuration @Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@Martin-Grunewald are the differences seen in the DQM test expected? They do not seem spurious, and involve non cosmics samples, I would like to ensure they are related to the changes introduced by this PR in an understood way |
Well, the newly added path is run on ALL samples, not just cosmics samples, as it is part of the GRun menu used nearly everywhere! |
@Martin-Grunewald sure, I understand that the differences you observe are expected ones (running a cosmics path on top of a TTbar event...) |
+1 |
PR description:
Adding cosmics path for HLT validation (110X)
Based on CMSSW_11_0_X_2019-10-06-2300
PR validation:
TSG tests
if this PR is a backport please specify the original PR:
N/A