Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cosmics path for HLT validation (110X) #28125

Merged
merged 1 commit into from Oct 9, 2019

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Oct 8, 2019

PR description:

Adding cosmics path for HLT validation (110X)
Based on CMSSW_11_0_X_2019-10-06-2300

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28125/12168

  • This PR adds an extra 628KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2830/console Started: 2019/10/08 10:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb378a/2830/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2960940
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960566
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.328 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 0.164 KiB HLT/GeneralHLTOffline
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2841/console Started: 2019/10/08 23:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb378a/2841/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2960940
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960566
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.328 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.164 KiB HLT/GeneralHLTOffline
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2019

@Martin-Grunewald are the differences seen in the DQM test expected? They do not seem spurious, and involve non cosmics samples, I would like to ensure they are related to the changes introduced by this PR in an understood way

@Martin-Grunewald
Copy link
Contributor Author

Well, the newly added path is run on ALL samples, not just cosmics samples, as it is part of the GRun menu used nearly everywhere!

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2019

@Martin-Grunewald sure, I understand that the differences you observe are expected ones (running a cosmics path on top of a TTbar event...)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2019

+1

@cmsbuild cmsbuild merged commit f88f3dd into cms-sw:master Oct 9, 2019
@Martin-Grunewald Martin-Grunewald deleted the HLTcosmics110X branch October 27, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants