Make getEngine() private in random service #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the random number generator service, make the getEngine function which takes no arguments be private instead of public. This function is replaced by new getEngine functions that take either a StreamID or a LuminosityBlockIndex as an argument. This comes after a long migration of all clients to the new interface. The new interace is designed to work with the multithreaded Framework. Note this may cause some problems when automatically merged from 7_1_X to 7_1_THREADED_X. There will be a separate pull request to the 7_1_THREADED_X branch soon after the automatic merge occurs which will resolve the problems and also delete the function entirely on that branch.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X. Make getEngine() private in random service It involves the following packages: FWCore/Utilities @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Mar 12, 2014
IOMC/RandomEngine -- Make getEngine() private in random service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the random number generator service, make the
getEngine function which takes no arguments be
private instead of public. This function is replaced
by new getEngine functions that take either a StreamID
or a LuminosityBlockIndex as an argument. This comes
after a long migration of all clients to the new
interface. The new interace is designed to work with
the multithreaded Framework.
Note this may cause some problems when automatically
merged from 7_1_X to 7_1_THREADED_X. There will be
a separate pull request to the 7_1_THREADED_X branch
soon after the automatic merge occurs which will
resolve the problems and also delete the function
entirely on that branch.