Muon FSR recovery for miniaod and nanoaod [106X]

[peruzzim]

backport #28118

Rebase of #28118 on the 10_6_X branch
@arizzi @gpetruc

[cmsbuild]

A new Pull Request was created by @peruzzim for CMSSW_10_6_X.

It involves the following packages:

DataFormats/PatCandidates
MuonAnalysis/MuonAssociators

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @calderona, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @rovere, @hatakeyamak, @gpetruc, @battibass, @trocino, @folguera, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Muon FSR recovery for miniaod and nanoaod  #28118

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2857/console Started: 2019/10/09 20:43

[cmsbuild]

+1
Tested at: 2956bf5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3be746/2857/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3be746/2857/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212305
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211970
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

Pull request #28136 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #28136 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28182,#28094
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3052/console Started: 2019/10/21 14:35

[cmsbuild]

+1
Tested at: 3062388
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f17b7/3052/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f17b7/3052/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 105 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212305
• DQMHistoTests: Total failures: 97
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3211871
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.845 KiB( 32 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 1.845 KiB Physics/NanoAODDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #28136 3062388

• changes since the last reco signoff are in the analysis category code backporting Fix electron PFCandidates RefVector usage in MuonFSRProducer #28221
• jenkins tests pass

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1