Thread safety issues #2816
Merged
Thread safety issues #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark mutable so static analyzer knows it is protected by atomic. Fix thread safety issue in the copy constructor. Use default memory behavior in the atomic functions.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X. Thread safety issues It involves the following packages: MagneticField/Engine @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
| @@ -59,7 +59,7 @@ class MagneticField | |||
| //nominal field value | |||
| virtual int computeNominalValue() const; | |||
| mutable std::atomic<char> nominalValueCompiuted; | |||
| mutable int theNominalValue; | |||
| [[cms::thread_guard("nominalValueCompiuted")]] mutable int theNominalValue; | |||
nclopezo
added a commit
that referenced
this pull request
Mar 13, 2014
MagneticField/Engine -- Thread safety issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark mutable so static analyzer knows it is protected
by atomic. Fix thread safety issue in the copy constructor.
Use default memory behavior in the atomic functions.