[10.6.X] Dynamical APV gain simulation (backport) #28160

mmusich · 2019-10-11T15:19:44Z

PR description:

Combined back-port of:

Simulation of APV dynamic gain #27823: Simulation of APV dynamic gain
Add SiStripApvSimulationParameters database object and record #27941: Add SiStripApvSimulationParameters database object and record
Add APV simulation in PreMixingSiStripWorker #28028: Add APV simulation in PreMixingSiStripWorker
Simulate APV dynamic gain in TID and TEC #28081: Simulate APV dynamic gain in TID and TEC

PR validation:

Validated by cherry-picking commits from PRs #28024 introducing special testing wfs in master

cmsrel CMSSW_10_6_X_2019-10-09-1100
cd CMSSW_10_6_X_2019-10-09-1100/src/
git cms-init
git cms-merge-topic CMSTrackerDPG:apv_dynamical_gain_simulation_10_6_X
cmsenv
git cms-addpkg Configuration/PyReleaseValidation
git cherry-pick b48f40164749f2e047c5e688e58eff089190db28
git cherry-pick 6d65ed7acf9dd01f15387469eab33d5508dd16b0
git cherry-pick 4fca3de96745d2b2d5e293133799d5a6d7e7e752
git cherry-pick 2ffa8135eaa8b5e832f0e5910e2f06775280f5a9
git cherry-pick 3ca3003f5770544486c53dfc77371de9b70d3caf
git cherry-pick e9ab9299c489e760642b764a1a40cc795ec99fd5
git cherry-pick 2f88d522865f4243ad0ff0bc591865db660ea575
scramv1 b -j 8 
runTheMatrix.py -l 1325.9,25202.1,250202.2,250202.3 -t 4 -j 8 --ibeos --command='-n 10'

it run to completion.

if this PR is a backport please specify the original PR:

#27823, #27941, #28028, #28081

cc:
@EmyrClement @pieterdavid @robervalwalsh @tsusa @mtosi @JanFSchulte

including an ESSource, and EDAnalyzer to add to the database

…gramF3D

Use SiStripApvSimulationParameters from EventSetup in SiStripDigitizer Use SiStrip APV simulation baseline ascii files from SimTracker/SiStripDigitizer/data SiStripDIgitizerAlgorithm: use enum for tracker partitions Address PR comments. Make output collections unique_ptr from start Use emplace_back instead of push_back. Reserve size for vectors holding output collections if known Fix creation of output containers Reorganise new class members Fix to avoid potentially negative charge deposits after simulating APV gain.

…ore bool with decision.

…pWorker

cmsbuild · 2019-10-11T15:20:48Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_6_X.

It involves the following packages:

CalibTracker/SiStripESProducers
CondCore/SiStripPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/PhysicsToolsObjects
CondFormats/SiStripObjects
CondTools/SiStrip
SimGeneral/MixingModule
SimTracker/SiStripDigitizer

@civanch, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @erikbutz, @makortel, @pieterdavid, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @prolay, @ebrondol, @tocheng, @mmusich, @threus, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2019-10-11T16:24:43Z

please test

cmsbuild · 2019-10-11T16:25:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2898/console Started: 2019/10/11 18:26

cmsbuild · 2019-10-11T19:03:50Z

+1
Tested at: 7198b8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce7ee/2898/summary.html

cmsbuild · 2019-10-11T19:03:54Z

Comparison job queued.

cmsbuild · 2019-10-11T21:08:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce7ee/2898/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3212305
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211969
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ggovi · 2019-10-14T13:49:58Z

+1

civanch · 2019-10-15T15:20:14Z

+1

pohsun · 2019-10-21T04:11:35Z

+1

cmsbuild · 2019-10-21T04:12:09Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2019-11-22T22:44:59Z

@fabiocos @srimanob can you clarify the intended trajectory of this PR (fully signed since 1 month)? To complete the backport of the APV simulation we need to add the combined commits of #28355 and #28454.
I would prefer to do it in a separate PR, but this presumes this is merged first. Can you clarify?
Thanks

fabiocos · 2019-11-23T20:31:30Z

+1

fabiocos · 2019-11-23T20:35:42Z

@mmusich this PR was waiting for a validation and a decision about its backport, that we now have, in this sense being signed does not imply any automatic integration.
I agree that it is preferable to backport the new PRs separately, this is now integrated to help in that.

mmusich · 2019-11-23T21:20:39Z

@fabiocos, thanks!

pieterdavid and others added 16 commits October 4, 2019 12:30

Add SiStripApvSimulationParameters and associated record

be787d9

including an ESSource, and EDAnalyzer to add to the database

Fix a bug (typo) in a constructor of PhysicsTools::Calibration::Histo…

2e6360f

…gramF3D

SiStripApvSimulationParameters: add members for TID and TEC partitions

cbe2d8a

SiStripApvSimulationParameters: rename ring->wheel, z->r

8c315ef

Update ESProducer for TID and TEC

f7da7b3

Add functionality to only simulate APV for fraction of events, and st…

566906b

…ore bool with decision.

use StripSubdetector namespace in 10.6.X

ccb464f

Add APV simulation in PreMixingSiStripWorker

cb65ffa

store bool if dynamic gain is used, remove printout

5c7fcbb

adapt SiStripApvSimulationParametersESProducer to have optional EndCaps

c51b292

use StripSubdetector instead of SiStripSubdetector in PreMixingSiStri…

8a64b37

…pWorker

Include TID and TEC in APV dynamic gain simulation

006f48b

Include feature in premixing workflow

a5fc51c

Add TID/TEC files to ESSource config

221f332

Make parameters untracked.

7198b8f

cmsbuild added this to the CMSSW_10_6_X milestone Oct 11, 2019

cmsbuild added alca-pending comparison-pending db-pending orp-pending pending-signatures simulation-pending tests-pending labels Oct 11, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 11, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 11, 2019

cmsbuild added db-approved and removed db-pending labels Oct 14, 2019

cmsbuild added simulation-approved and removed simulation-pending labels Oct 15, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 21, 2019

mmusich mentioned this pull request Nov 6, 2019

Activate SiStrip APV Simulation for 2016 MC #28355

Merged

cmsbuild added orp-approved and removed orp-pending labels Nov 23, 2019

cmsbuild merged commit e12b4e3 into cms-sw:CMSSW_10_6_X Nov 23, 2019

mmusich mentioned this pull request Nov 29, 2019

[10.6.X] Activate SiStrip Dynamical APV gain simulation for 2016 UL MC #28512

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.6.X] Dynamical APV gain simulation (backport) #28160

[10.6.X] Dynamical APV gain simulation (backport) #28160

mmusich commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

christopheralanwest commented Oct 11, 2019

cmsbuild commented Oct 11, 2019 •

edited

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

ggovi commented Oct 14, 2019

civanch commented Oct 15, 2019

pohsun commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

mmusich commented Nov 22, 2019

fabiocos commented Nov 23, 2019

fabiocos commented Nov 23, 2019

mmusich commented Nov 23, 2019

[10.6.X] Dynamical APV gain simulation (backport) #28160

[10.6.X] Dynamical APV gain simulation (backport) #28160

Conversation

mmusich commented Oct 11, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Oct 11, 2019

christopheralanwest commented Oct 11, 2019

cmsbuild commented Oct 11, 2019 • edited

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

ggovi commented Oct 14, 2019

civanch commented Oct 15, 2019

pohsun commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

mmusich commented Nov 22, 2019

fabiocos commented Nov 23, 2019

fabiocos commented Nov 23, 2019

mmusich commented Nov 23, 2019

cmsbuild commented Oct 11, 2019 •

edited