Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect reflex protection from HcalDbService #2817

Merged
merged 1 commit into from
Mar 12, 2014

Conversation

Dr15Jones
Copy link
Contributor

The CPP conditional code to protect reflex from the C++11 syntax was
done incorrectly since the the memory layout of the two options were
not identical. Given that this file is never scanned by Reflex, it is
best to just remove the conditional code.

The CPP conditional code to protect reflex from the C++11 syntax was
done incorrectly since the the memory layout of the two options were
not identical. Given that this file is never scanned by Reflex, it is
best to just remove the conditional code.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Remove incorrect reflex protection from HcalDbService

It involves the following packages:

CalibFormats/HcalObjects

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Mar 12, 2014

+1
Provided Jenkins agrees

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 12, 2014
CalibFormats/HcalObjects -- Remove incorrect reflex protection from HcalDbService
@nclopezo nclopezo merged commit 2db51e5 into cms-sw:CMSSW_7_1_X Mar 12, 2014
@Dr15Jones Dr15Jones deleted the fixBugInHcalDbService branch March 17, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants