Enable ME0TriggerPseudoDigiProducer in Phase-2 L1T sequence

[dildick]

PR description:

Following a request by folks in the GEM DPG who are studying LFV tau to 3 muon decay, I'm enabling the ME0TriggerPseudoDigiProducer in the Phase-2 L1T sequence. This PR also addresses a question that was asked a while ago here. I should note that these ME0TriggerDigi can also be used in the Phase-2 EMTF in the near future.

I did rename the configuration from me0TriggerPseudoDigis_cfi to me0TriggerConvertedPseudoDigis_cfi, otherwise me0TriggerPseudoDigis_cfi would clash with modules defined in me0TriggerPseudoDigis_cff. (The new objects are in fact converted ME0Segments.) I also added the standard me0RecHits and me0Segments modules in the sequence so that me0TriggerConvertedPseudoDigis has all the required inputs.

PR validation:

I ran matrix test 20434.0 to check that the triggers are produced and saved in the event content. That is indeed the case as you can see below. The new Converted pseudo digis are of type ME0TriggerDigi in contrast to me0TriggerPseudoDigis which is of type ME0Segment.

-bash-4.2$ edmEventSize -a -v step2.root | grep me0Trigger
ME0DetIdME0SegmentsOwnedRangeMap_me0TriggerPseudoDigis__HLT. 1299 666
ME0DetIdME0TriggerDigiMuonDigiCollection_me0TriggerConvertedPseudoDigis__HLT. 495.6 328.2

FYI: @tahuang1991 @mmaggi

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28183/12268

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/ME0Trigger

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @jshlee this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2991/console Started: 2019/10/16 18:46

[cmsbuild]

+1
Tested at: a98d6fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a4a53/2991/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a4a53/2991/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[fabiocos]

@rekovic @benkrikler please scrutinize this PR

[fabiocos]

the net impact on the step2 output size for wf 20434.0 is of the order of 0.1%

[dildick]

@fabiocos This PR shouldn't have any effect on L1T producers downstream since me0TriggerConvertedPseudoDigis is not yet used by the EMTF and we don't have a validation module for it yet.

[dildick]

@rekovic Can you sign off, please?

[fabiocos]

@rekovic I would lile to move forward with this PR, unless you have comments/issues to raise

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

Thanks!

[fabiocos]

+1