DD4Hep: Update to the new DD4hep version

[ianna]

PR description:

• New API for an instance checks: isA checks is the Shape is an exact type, isInstance checks if the Shape is a derived type, instanceOf is deprecated
• Update tests reference
• Cleanup tests and test scripts

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[ianna]

@mrodozov - FYI

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28224/12364

• This PR adds an extra 80KB to repository

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/DTGeometryBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test with cms-sw/cmsdist#5285

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5285
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3058/console Started: 2019/10/21 17:54

[cmsbuild]

-1

Tested at: 03c37b9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd793f/3058/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5292
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3073/console Started: 2019/10/21 23:00

[ianna]

I do not see what the error is, but it's unrelated to this PR:

===== Test "materialBudgetTrackerPlots" ====
+ VGEO_DIR=/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry
+ TEST_DIR=/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/materialBudgetTrackerPlots
+ '[' -d /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/materialBudgetTrackerPlots ']'
+ mkdir /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/materialBudgetTrackerPlots
+ cd /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/materialBudgetTrackerPlots
+ cmsRun /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/single_neutrino_cfg.py nEvents=1000
+ for geom in '{'\''Extended2015'\'','\''Extended2017Plan1'\''}'
+ cmsRun /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_DEVEL_X_2019-10-20-2300/src/Validation/Geometry/test/runP_Tracker_cfg.py geom=Extended2015 label=Tracker

---> test materialBudgetTrackerPlots had ERRORS

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd793f/3058/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1497 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

+1
Tested at: 03c37b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dd323/3073/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dd323/3073/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@ianna, all look good.
@fabiocos , this should go with cms-sw/cmsdist#5292

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1