Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY3] Set PYTHONHOME to python2 to fix PyDevParameterSet unittest #28317

Merged
merged 1 commit into from
Nov 1, 2019
Merged

[PY3] Set PYTHONHOME to python2 to fix PyDevParameterSet unittest #28317

merged 1 commit into from
Nov 1, 2019

Conversation

smuzaffar
Copy link
Contributor

This shoudl fix the PY3 IB unit test for FWCore/PyDevParameterSet. For PY3 IBs , PyDevParameterSet is linked to python2 but python executable points to python3 this make pybind11 to fail as it tries to look for python2 shared libs under python3/lib path.

This change will only set PYTHONHOME to python2 path for PY3 IBs.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28317/12559

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3273/console Started: 2019/10/30 18:14

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

FWCore/PyDevParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13cb6c/3273/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961036
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960694
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Oct 30, 2019

@fabiocos , can we get this in IB, this just fixes a unit test for PY3 IBs.

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 1, 2019

@smuzaffar this looks as a temporary workaround right?

@fabiocos
Copy link
Contributor

fabiocos commented Nov 1, 2019

+1

to be verified in next IB

@cmsbuild cmsbuild merged commit b1e58f3 into cms-sw:master Nov 1, 2019
@smuzaffar
Copy link
Contributor Author

correct, this is just to workaround for py3. Once we full move to py3 then the package PyDevParameterSet will be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants