-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PY3] Set PYTHONHOME to python2 to fix PyDevParameterSet unittest #28317
[PY3] Set PYTHONHOME to python2 to fix PyDevParameterSet unittest #28317
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28317/12559
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: FWCore/PyDevParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@fabiocos , can we get this in IB, this just fixes a unit test for PY3 IBs. |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar this looks as a temporary workaround right? |
+1 to be verified in next IB |
correct, this is just to workaround for py3. Once we full move to py3 then the package PyDevParameterSet will be removed |
This shoudl fix the PY3 IB unit test for FWCore/PyDevParameterSet. For PY3 IBs , PyDevParameterSet is linked to python2 but
python
executable points topython3
this make pybind11 to fail as it tries to look for python2 shared libs under python3/lib path.This change will only set PYTHONHOME to python2 path for PY3 IBs.