Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop EI from AOD data tier #28326

Merged
merged 1 commit into from
Nov 8, 2019
Merged

drop EI from AOD data tier #28326

merged 1 commit into from
Nov 8, 2019

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Oct 31, 2019

EI products take almost 2% of AOD.
These were introduced before we had miniAOD as a standard reference.

@rappoccio @arizzi @gpetruc @peruzzim @fgolf
in case you know of any use case from your current/past PAT/miniAOD knowledge base.

@mbluj @swozniewski pfTausDiscriminationByDecayModeFinding and pfTausDiscriminationByIsolation are kept only via CommonTools/ParticleFlow/python/EITopPAG_EventContent_cff.py
Is there any use case for these products?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28326/12576

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/EventContent

@cmsbuild, @franzoni, @fabiocos, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 31, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3288/console Started: 2019/10/31 17:41

@mbluj
Copy link
Contributor

mbluj commented Oct 31, 2019

@mbluj @swozniewski pfTausDiscriminationByDecayModeFinding and pfTausDiscriminationByIsolation are kept only via CommonTools/ParticleFlow/python/EITopPAG_EventContent_cff.py
Is there any use case for these products?

These products looks as copies of "regular" tau reco products (probably with modified inputs) which are stored via RecoTauTag/Configuration/python/RecoTauTag_EventContent_cff.py. I am not aware of any use case of these "EI taus".

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10033e/3288/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 2, 2019

@rappoccio @arizzi @gpetruc @peruzzim @fgolf before I integrate this PR could some of you comment?

@fabiocos
Copy link
Contributor

fabiocos commented Nov 2, 2019

@slava77 in the meanwhile I have integrated #28328 that is related to this PR

@slava77
Copy link
Contributor Author

slava77 commented Nov 4, 2019

@ahinzmann @knash @lathomas
tagging you, since there is also a somewhat related private thread.
Note that the EI collections can be remade from AOD (#28328)

@ahinzmann
Copy link
Contributor

@slava77 We confirmed with our TOP-PAG jet contact that no analysis in TOP is using this EI in AOD at the moment.

@slava77
Copy link
Contributor Author

slava77 commented Nov 8, 2019

@slava77 We confirmed with our TOP-PAG jet contact that no analysis in TOP is using this EI in AOD at the moment.

Thank you.
AFAIK, TOP DQM was even the only customer for this in the physics DQM pieces.
IIRC, the setup itself was based in part on TQAF selections.
So, it sounds safe to drop it then.
@fabiocos please consider including this in pre12.
Thank you.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2019

+operations

no negative reaction from experts inquired

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants