mark mutable atomic_value_ptr members as CMS_THREAD_SAFE in [V]ParamererSetEntry

[slava77]

based on what's apparently false-positive reports of thread unsafety by the static analyzer.

I expect that this PR will substantially reduce the total count of warnings (IIUC, this count is replicated from every include and use case of [V]ParameterSetEntry)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28331/12589

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3300/console Started: 2019/11/01 14:48

[cmsbuild]

+1
Tested at: 62bbc92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31efcb/3300/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31efcb/3300/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939026
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2938684
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

@Dr15Jones
are there concerns about this change?

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[slava77]

looking at the static analyzer results between CMSSW_11_0_X_2019-11-10-0000 and CMSSW_11_0_X_2019-11-10-2300, I conclude that this PR reduced the number of issues in the category "mutable member if accessed via const pointer " from 80.7K to 67.1K (17%).