Fixes to the ZeroBias DQM sequences #28336
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28336/12600
|
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: DQMOffline/Configuration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 134.71,136.789,136.801,136.88 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@jfernan2 this PR appears to fix the residual crashes in the IB. I am not sure this is what you intended to get in your revision, please have a look. In case I will integrate them in one of the next IBs and then you may go through a further update. |
|
@smuzaffar FYI |
|
+1 |
|
merge |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
|
I understand, I am working now on a fix to your fix to have it as desired, I will commit a PR this morning |
| @@ -1,18 +1,18 @@ | |||
| autoDQM = { 'common': ['@dcs+DQMMessageLoggerSeq+@strip+@pixel+@tracking+@L1TMon+@hlt+@beam+@castor+@physics+@tau', | |||
| 'PostDQMOffline', | |||
| '@dcs+DQMMessageLoggerSeq+@strip+@pixel+@tracking+@L1TMon+@hlt+@beam+@fed+@tau+dqmFastTimerServiceClient'], | |||
There was a problem hiding this comment.
That was the approach I was testing now... Thanks!
I am not sure the ZB workflows are part of the limited or short matrices (so might have escaped internal scrutiny). |
|
@mmusich no, these ZB workflows are a bit special and not part of the current short matrix: I am not terribly concerned about this, as they are run in any IB, and this is likely the reason why @jfernan2 missed it, unless he did an explicit test. Breaking the IB for a few rounds for such a large refactoring is not something terrible, provided we fix it quickly, and I try to wait the last moment before an important build for this kind of migrations. And if we pick one we might miss an issue in another (there were two distinct categories of problems in this case). It is clear that whatever new implementation will have to be explicitly tested against this subset of dedicated workflows. |
|
I second the proposal by @mmusich . Despite I made runThematrix -i all it seems I totally missed these failures in the jungle of outputs provided by the command which went beyond the total capacity of my local account. Thanks |
PR description:
This PR is a follow-up of #28325 to fix the crashes after the revision of DQM sequences in #28156 .
There are two changes:
the DQMMessageLogger sequence for harvesting step is updated;
the tracker ZeroBias sequence is moved back to the old value.
Both changes need to be validated by @jfernan2
PR validation:
workflows 134.71 and 136.856 run, the previously appearing warning on missing sequence in harvesting has disappeared.