Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setNewRun() and setNewLumi() should work always #2834

Merged
merged 1 commit into from
Mar 13, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 12, 2014

The classes ProducerSourceBase and ProducerSourceFiles provide a setNewRun call and a setNewLumi call
for input sources derived from these classes to indicate a new run or lumi. However, these calls do not work if called from setRunAndLumiInfo(), unless the run or lumi number changed, in which case the call is not needed.
This pull request ensures that a call to setNewRun() or setNewLumi() will cause a new run or new lumi transition.
This fix is needed by LHESource to process LHE input files with different headers in the same job.
This pull request needs normal testing and signature requirements.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

setNewRun() and setNewLumi() should work always

It involves the following packages:

FWCore/Sources

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 13, 2014
FWCore/Sources -- setNewRun() and setNewLumi() should work always
@nclopezo nclopezo merged commit 669535c into cms-sw:CMSSW_7_1_X Mar 13, 2014
@wmtan wmtan deleted the setNewRunMustWork branch March 21, 2014 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants