Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102X backport of isolated particle level photons #28409

Merged

Conversation

AndrewLevin
Copy link
Contributor

@AndrewLevin AndrewLevin commented Nov 15, 2019

PR description:

Replaces the current photon collection in the Rivet particle level producer with a collection of isolated photons. The photon pt cut, photon eta cut, isolation cone size, and isolation cut are configurable.

PR validation:

I have run this producer on a recent TTBar and HGG relval sample, and found that the producer produces the expected number of isolated photons in each case.

if this PR is a backport please specify the original PR:

#28371

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AndrewLevin for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/RivetInterface
PhysicsTools/NanoAOD

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @fgolf, @alberto-sanchez, @agrohsje, @qliphy, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc, @alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Nov 17, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3506/console Started: 2019/11/17 01:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7873e0/3506/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007491
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007300
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 17, 2019

+1

@santocch
Copy link

+1

@AndrewLevin
Copy link
Contributor Author

Can this be merged?

@peruzzim
Copy link
Contributor

peruzzim commented Dec 5, 2019

+xpog

reiterating #28371 (comment): should be clearly announced once it enters releases actively used for analysis - could you please take care of this? @intrepid42 @qliphy

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c45808a into cms-sw:CMSSW_10_2_X Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants