Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix double counting of ovflw bin #2841

Merged
merged 3 commits into from
Mar 17, 2014
Merged

fix double counting of ovflw bin #2841

merged 3 commits into from
Mar 17, 2014

Conversation

folguera
Copy link
Contributor

Fix double counting of ovflw bin in DQMOffline/Muon/

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @folguera (Santiago Folgueras) for CMSSW_7_1_X.

fix double counting of ovflw bin

It involves the following packages:

DQMOffline/Muon

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2841 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@nclopezo
Copy link
Contributor

@folguera
Hi Santiago,
This pull request is unmergeable, could you please rebase it?

@folguera
Copy link
Contributor Author

Sorry for my ignorance, what is rebasing? You mean to create a new pull request using as base release CMSSW_7_1_X? Shall I close this one then?

@nclopezo
Copy link
Contributor

You can see instructions on how to do it here:
http://cms-sw.github.io/cmssw/tutorial-forward-port.html

@folguera
Merged MuonDQM-MuonIsolationFix from repository folguera
b66439b 
Conflicts:
	Validation/MuonIsolation/src/MuIsoValidation.cc

remove some empty lines that caused the crashing
@folguera
Copy link
Contributor Author

Thanks! hope now it is fixed.

@cmsbuild
Copy link
Contributor

Pull request #2841 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2841/503/summary.html

@deguio
Copy link
Contributor

deguio commented Mar 17, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 17, 2014
@nclopezo
Merge pull request #2841 from folguera/MuonDQM-MuonIsolationFix
0956fb0 
DQMOffline fix double counting of ovflw bin
@nclopezo nclopezo merged commit 0956fb0 into cms-sw:CMSSW_7_1_X Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@folguera @cmsbuild @nclopezo @deguio