Phase out old pre-GED GsfElectron sequence

[guitargeek]

PR description:

This PR suggests to remove the old gsfElectron sequence and it's producers, which are not in use anymore since the rewrite between Run I and II in the context of the GED (global event description) campaign. This would be a big step for the egamma code cleanup. Other producers would not have to support the old workflow anymore (which can result in a good reduction of the number of configuration parameters) helpers that were only used by the old producers can be removed, etc.

Still, this cleanup is not completely trivial because there is a whole relval-step (RECODFROMRAWRECO) which still depends on the old sequences. I am not completely familiar with these relval-steps so maybe I'm doing a mistake by proposing also the removal of this step, but it seems to me that the step is not supported anymore anyway: in the MatrixReader, it's hardcoded that this step is ignored [1,2], and the word RECODFROMRAWRECO appears nowhere else in CMSSW. The other remaining use of the old gsfElectronSequence was in the cosmicElectronSequence. However, this is not used anywhere: the cosmic reconstruction uses only the egammarecoCosmics_woElectrons sequence.

@Sam-Harper, @jainshilpi, @lsoffi, please let us know if you think if this is a good idea or if you think the old GsfElectronProducer should still stick around. I think this is a very good opportunity to reduce quite a bit the complexity of the egamma reco area and hence render it easier to understand and to work with.

[1] https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/MatrixReader.py#L243
[2] https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/MatrixReader.py#L341
[3] https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/ReconstructionCosmics_cff.py#L59

PR validation:

CMSSW compiles and local matrix tests pass.

if this PR is a backport please specify the original PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28429/12826

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Activate SiStrip APV Simulation for 2016 MC #28355, Fix DQM ZB workflows and moved DQM FS configuration to DQM package #28351, ECAL for Time dependent MC. Premix option C. Handle for APD/PN tag for time dependence #28214, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Configuration/PyReleaseValidation
Configuration/StandardSequences
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers
RecoHI/HiEgammaAlgos

@perrotta, @cmsbuild, @chayanit, @zhenhu, @slava77, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@VinInn, @jazzitup, @Sam-Harper, @yetkinyilmaz, @makortel, @felicepantaleo, @jainshilpi, @afiqaize, @GiacomoSguazzoni, @tocheng, @lgray, @Martin-Grunewald, @yenjie, @rovere, @kurtejung, @varuns23, @mmusich, @argiro, @mandrenguyen, @dgulhan, @sobhatta this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3546/console Started: 2019/11/20 07:46

[cmsbuild]

-1

Tested at: 7352909

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba7aa5/3546/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

• RelVals:

When I ran the RelVals I found an error in the following workflows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Nov 20 08:59:03 2019-date Wed Nov 20 08:58:53 2019 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Wed Nov 20 08:59:20 2019-date Wed Nov 20 08:59:13 2019 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Wed Nov 20 08:59:32 2019-date Wed Nov 20 08:59:24 2019 s - exit: 256

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[kpedro88]

+upgrade

[chayanit]

+1

[silviodonato]

+operations

[silviodonato]

alca (@christopheralanwest @franzoni @tlampen @pohsun @tocheng ) please review/sign

[tlampen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1