Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to "consumes" of RecoMuon/GlobalTrackingTools #2844

Merged
merged 25 commits into from Mar 17, 2014
Merged

migration to "consumes" of RecoMuon/GlobalTrackingTools #2844

merged 25 commits into from Mar 17, 2014

Conversation

dr4kan
Copy link
Contributor

@dr4kan dr4kan commented Mar 13, 2014

This PR is for the migration to "consumes" of RecoMuon/GlobalTrackingTools. Dependencies on other modules have also been resolved.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dr4kan (Davide Pagano) for CMSSW_7_1_X.

migration to "consumes" of RecoMuon/GlobalTrackingTools

It involves the following packages:

FastSimulation/Muons
RecoHI/HiMuonAlgos
RecoMuon/GlobalMuonProducer
RecoMuon/GlobalTrackFinder
RecoMuon/GlobalTrackingTools
RecoMuon/L3TrackFinder
RecoMuon/TrackerSeedGenerator

@nclopezo, @lveldere, @cmsbuild, @anton-a, @thspeer, @giamman, @slava77, @Degano can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @bachtis, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 14, 2014

@nclopezo
Hi David,
It's been 2 hours since +1 from cmsbuild, but

Comparison with the baseline    Still running...

I proposed earlier not to send a +1 from cmsbuild if the tests are not completed.

Please check

Thanks

@slava77
Copy link
Contributor

slava77 commented Mar 17, 2014

.. now it's two days later and jenkins diff status

Comparison with the baseline    Still running...

@slava77
Copy link
Contributor

slava77 commented Mar 17, 2014

+1

for #2844 b7dd481
tested with a short matrix locally in CMSSW_7_1_X_2014-03-12-1400/sign323

no differences as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

@slava77
There was a problem with the machine that executed the comparison.
The +1 from the tests is given if there are no errors compiling, in the unit tests or the Relvals. The other tests that are run are used by the people that sign to pull request to make the decision. Some of them don't run always, like the DQM tests. The comparisons take around 1 hour, and when the IBs are being built, the comparisons can stay in the queue longer so the result from Jenkins would take longer to appear. And when there are many pull requests pending for testing this can make that the results take longer to appear.
@ktf I can change the behaviour if necessary, to make jenkins wait for the comparisons to finish before posting the +1

nclopezo added a commit that referenced this pull request Mar 17, 2014
RecoMuon -- migration to "consumes" of RecoMuon/GlobalTrackingTools
@nclopezo nclopezo merged commit 71873e9 into cms-sw:CMSSW_7_1_X Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants