Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to write out all ALCTs and CLCTs #28467

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Option to write out all ALCTs and CLCTs #28467

merged 4 commits into from
Dec 9, 2019

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Nov 25, 2019

PR description:

Current CSC trigger simulation only allows for max 2 ALCTs and max 2 CLCTs per chamber. MC studies are ongoing that investigate possibilities to trigger on exotic signatures which produce >2 ALCTs or >2 CLCTs. Such signatures may include long-lived particles that decay to multiple muons.

This PR introduces an option in the CSC trigger to write out specific ALCT and CLCT collections with the label "All" for such exotica studies. These collections are only useful when MAX_ALCTS_PER_PROCESSOR and MAX_CLCTS_PER_PROCESSOR is greater than 2. By default the option is turned off, so there is no change in the trigger performance.

PR validation:

Tested it with a 2026 runTheMatrix command.

if this PR is a backport please specify the original PR:

N/A

@tahuang1991

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28467/12904

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@dildick
Copy link
Contributor Author

dildick commented Nov 25, 2019

I fixed this in my last commit.

@dildick
Copy link
Contributor Author

dildick commented Nov 26, 2019

@fabiocos Is the cmsbuild state machine stuck in this PR?

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28467/12965

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3696/console Started: 2019/11/29 15:04

@cmsbuild
Copy link
Contributor

@smuzaffar smuzaffar modified the milestones: CMSSW_11_0_X, CMSSW_11_1_X Dec 2, 2019
@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3819/console Started: 2019/12/05 16:52

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

@rekovic could you please have a look?

@dildick this PR in its default configuration does not modify anything. What is the expected increase in output size in case the flags are switched to true?

@dildick
Copy link
Contributor Author

dildick commented Dec 5, 2019

That depends on the scenario. In low-pileup scenarios the "All" CLCT and ALCT collections will be just copies of the standard CLCT and ALCT collections. At PU200, there could be many more CLCTs and ALCTs per chamber... So the size could increase with a factor 2 to perhaps even 5. But in any case, the flags writeOutAllCLCTs and writeOutAllALCTs should not be set to True for any official MC production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6369c1/3819/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799742
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Dec 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 9, 2019

+1

@cmsbuild cmsbuild merged commit 431e2fd into cms-sw:master Dec 9, 2019
@dildick dildick deleted the from-CMSSW_11_0_X_2019-11-20-1100-Save-ALL-ALCTs-CLCTs branch March 6, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants