-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent unit test failures #28530
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28530/13002
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Unrelated output in the log file was causing the diff to occasionally fail. Use grep to compare only the part we are interested in. Only affects unit test.
123c75e
to
952e587
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28530/13003
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: CondCore/ESSources @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@ggovi please check, this looks a technical fix, I will integrate it into next IB |
+1 |
merge |
PR description:
Unrelated output in the log file was causing the diff
to fail intermittently. Use grep to compare only the
part we are interested in. Only affects unit test.
PR validation:
Unit test passes now.
if this PR is a backport please specify the original PR:
Should I backport this to 11_0_X?