replace wildcards of cmssw class dictionaries to avoid duplicates #28541
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28541/13014
|
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DataFormats/Math @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Part of the work on #15248 |
|
Comparison is ready Comparison Summary:
|
|
@Dr15Jones - does this look like the correct fix to you? |
|
Seems good to me. |
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
I think this may be causing the unit test failure: which has |
|
Yes. Definitely. I’ll look this morning
On 5 Dec 2019, at 20:35, Chris Jones <notifications@github.com> wrote:
I think this may be causing the unit test failure:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_X_2019-12-05-1100/unitTestLogs/TauAnalysis/MCEmbeddingTools#/117-117
which has
…----- Begin Fatal Exception 05-Dec-2019 16:40:08 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=EmbeddingLHEProducer label='externalLHEProducer'
[2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:
edm::Wrapper<ROOT::Math::LorentzVector<ROOT::Math::PxPyPzE4D<double> > >
Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h
A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:
ROOT::Math::LorentzVector<ROOT::Math::PxPyPzE4D<double> >
----- End Fatal Exception -------------------------------------------------
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#28541?email_source=notifications&email_token=ABGPFQYXKQ5KFSLSLWFBQGTQXFJVZA5CNFSM4JVFEWEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGB34EI#issuecomment-562282001>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ3GJYQYSSKWH4E4JK3QXFJVZANCNFSM4JVFEWEA>.
|
as discussed in the core meeting yesterday, the wildcards in DataFormats/Math are giving duplicate dictionary definitions for some classes when using root modules. The use of wildcards for cmssw classes is not desired by the fwk group. This PR removes them and replaces them with what's needed to run matrix workflows (I tested a few)