-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters for high pT particle protection in PUPPI #28558
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13044
|
A new Pull Request was created by @ahinzmann for master. It involves the following packages: CommonTools/PileupAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13046
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13092
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add new parameter to PUPPI to deal with high pT particles. Recent studies have shown that the current handling of high momentum charged particles in PUPPI is suboptimal compared to CHS and a different configuration of PUPPI for Run3 is proposed.
https://indico.cern.ch/event/862332/contributions/3632864/
This PR implements the necessary switches without changing the current behavior of the algorithm, i.e. no changes to RECO+MiniAOD are expected from this PR.
At the same time the behavior of the parameter puppiNoLeptons, that is not used anywhere in CMSSW, is adapted such that implementation actually matches the name.
PR validation:
runtests
Backports
We would like to have these options backported to 10_6_X, to introduce a new PUPPI configuration for UL MiniAOD-v2 and for JMEcustomNanoAODs as soon as the PR is merged.