Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for high pT particle protection in PUPPI #28558

Merged
merged 4 commits into from
Dec 11, 2019

Conversation

ahinzmann
Copy link
Contributor

@ahinzmann ahinzmann commented Dec 5, 2019

PR description:

Add new parameter to PUPPI to deal with high pT particles. Recent studies have shown that the current handling of high momentum charged particles in PUPPI is suboptimal compared to CHS and a different configuration of PUPPI for Run3 is proposed.
https://indico.cern.ch/event/862332/contributions/3632864/
This PR implements the necessary switches without changing the current behavior of the algorithm, i.e. no changes to RECO+MiniAOD are expected from this PR.

At the same time the behavior of the parameter puppiNoLeptons, that is not used anywhere in CMSSW, is adapted such that implementation actually matches the name.

PR validation:

runtests

Backports

We would like to have these options backported to 10_6_X, to introduce a new PUPPI configuration for UL MiniAOD-v2 and for JMEcustomNanoAODs as soon as the PR is merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13044

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @riga, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13046

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Pull request #28558 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Dec 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3822/console Started: 2019/12/05 17:12
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3826/console Started: 2019/12/05 17:30
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3827/console Started: 2019/12/05 17:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28558/13092

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #28558 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3896/console Started: 2019/12/10 09:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a4c6/3896/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799742
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • A new parameterization is made available for puppi weights, as planned: justification for it is in the attached presentation, while a full large stat validation will follow.
  • puppiNoLepton updated to better corresponds to its name
  • Modified configs are not activated in the current workflows: no change in reco or miniAOD outputs onserved
  • Jenkins tests pass

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants