Use ESGetToken in FWRecoGeometryESProducer and FWTGeoRecoGeometryESProducer

[makortel]

PR description:

Title says it all. In addition, avoid two unnecessary copies of std::vector<DetId>.

PR validation:

Code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28564/13052

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3834/console Started: 2019/12/05 19:07

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@slomeo please repeat you test for D49 with this PR included

[cmsbuild]

+1
Tested at: b0e8fcd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c5a66/3834/summary.html

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[fabiocos]

@slomeo with this PR integrated:

17:02 cmsdev25 3073> cmsRun $CMSSW_RELEASE_BASE/src/Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2026 version=D49
Loading configuration for tag  2026 ...

Dumping geometry in  cmsRecoGeom-2026.root 

Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 06-Dec-2019 17:03:24.220 CET
HcalParametersFromDD: 2 layerGroupEtaSim blocks
layerGroupEtaSim[0] Layer 1 1:1 2:2 3:2 4:2 5:2 6:3 7:3 8:3 9:3 10:3 11:4 12:4 13:4 14:4 15:4 16:4 17:4 18:4 19:4
layerGroupEtaSim[1] Layer 16 1:1 2:1 3:2 4:2 5:2 6:3 7:3 8:3 9:3 10:3 11:4 12:4 13:4 14:4 15:4 16:4 17:4 18:4 19:4
HcalParametersFromDD: 4 etaMin values [1] = 1 [2] = 16 [3] = 29 [4] = 1
HcalParametersFromDD: 4 etaMax values [1] = 16 [2] = 15 [3] = 41 [4] = 15
HcalParametersFromDD: 4 etaRange values [1] = 1.392 [2] = 3 [3] = 5.5 [4] = 1.305
HcalParametersFromDD: 7 gparHF values [1] = 22 [2] = 165 [3] = 30 [4] = 0 [5] = 1115 [6] = 0.375 [7] = 1137
HcalParametersFromDD: 18 noff values [1] = 15 [2] = 99 [3] = 4 [4] = 10 [5] = 5 [6] = 2 [7] = 4 [8] = 18 [9] = 19 [10] = 11 [11] = 12 [12] = 13 [13] = 14 [14] = 3 [15] = 4 [16] = 3 [17] = 1 [18] = 0
HcalParametersFromDD: 2 Layer0Wt values [1] = 1.2 [2] = 1.2
HcalParametersFromDD: 4 Shift/Gains values for HB [0] = 0:117 [1] = 0:117 [2] = 0:117 [3] = 0:217
HcalParametersFromDD: 4 Shift/Gains values for HE [0] = 0:178 [1] = 0:178 [2] = 0:178 [3] = 0:0
HcalParametersFromDD: 4 Shift/Gains values for HF [0] = 0:2.84 [1] = 0:2.09 [2] = 0:2.84 [3] = 0:2.09
HcalParametersFromDD: 16 etagroup values [1] = 1 [2] = 1 [3] = 1 [4] = 1 [5] = 1 [6] = 1 [7] = 1 [8] = 1 [9] = 1 [10] = 1 [11] = 1 [12] = 1 [13] = 1 [14] = 1 [15] = 1 [16] = 1
HcalParametersFromDD: 16 phigroup values [1] = 1 [2] = 1 [3] = 1 [4] = 1 [5] = 1 [6] = 1 [7] = 1 [8] = 1 [9] = 1 [10] = 1 [11] = 1 [12] = 1 [13] = 1 [14] = 1 [15] = 1 [16] = 1
HcalParametersFromDD: 2 layerGroupEtaRec blocks
layerGroupEtaRec[0] Layer 1 1:1 2:2 3:2 4:2 5:2 6:3 7:3 8:3 9:3 10:3 11:4 12:4 13:4 14:4 15:4 16:4 17:4 18:4 19:4
layerGroupEtaRec[1] Layer 16 1:1 2:1 3:2 4:2 5:2 6:3 7:3 8:3 9:3 10:3 11:4 12:4 13:4 14:4 15:4 16:4 17:4 18:4 19:4
HcalParametersFromDD: (topology|trigger)Mode 602

=============================================

MessageLogger Summary

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------

dropped waiting message count 0

[fabiocos]

+1