Add enforceGUIDInFileName option to PoolSource (7_1_X)

[makortel]

PR description:

Quoting original PR

This PR adds an option to PoolSource and EmbeddedRootSource to enforce that the file name (without extension) corresponds the GUID of the file. The added configuration parameter is enforceGUIDInFileName = cms.untracked.bool, and is set to false by default to preserve the current behavior. In case of a mismatch a new error code 8034 (FileNameInconsistentWithGUID) is returned.

The motivation for such an option comes from dmwm/WMCore#9432.

PR validation:

Unit tests run.

if this PR is a backport please specify the original PR:

Backport of #28561. There some differences wrt. original PR: stemFromPath() operates on std::string instead of std::string_view, its unit test does not use catch2, and the set of clients of RootFile class is different (because of #9397).

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

It involves the following packages:

FWCore/Framework
FWCore/MessageLogger
FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3930/console Started: 2019/12/11 19:42

[cmsbuild]

-1

Tested at: a1bbef3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11c43b/3930/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testCoralSQLPrinting had ERRORS

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11c43b/3930/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 682523
• DQMHistoTests: Total failures: 3093
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 679056
• DQMHistoTests: Total skipped: 374
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
• Checked 44 log files, 4 edm output root files, 11 DQM output files

[makortel]

The unit test failure is

PluginManager Info PluginManager creating CORAL/RelationalPlugins/oracle component
PluginManager Info PluginManager needs to load CORAL/RelationalPlugins/oracle component
PluginManager Info PluginManager loaded OracleAccess library
PluginManager Info PluginManager loaded CORAL/RelationalPlugins/oracle factory from OracleAccess library
cond::XMLAuthenticationService::verifyFileName Debug File "authentication.xml" not found in the current directory. Trying in the search path.
cond::XMLAuthenticationService::verifyFileName Debug Search path "/afs/cern.ch/cms/DB/conddb" does not exist.
cond::XMLAuthenticationService::initialize Debug Could not open "authentication.xml" for reading
CORAL/Services/ConnectionService Debug Could not retrieve credentials for connection "oracle://cms_orcoff_prep/CMS_COND_UNIT_TESTS" from authentication service: Connection string "oracle://cms_orcoff_prep/CMS_COND_UNIT_TESTS" is not known to the service ( CORAL : "IAuthenticationService::credentials" from "COND/Services/XMLAuthenticationService" )
CORAL/Services/ConnectionService Warning Replica on connection "oracle://cms_orcoff_prep/CMS_COND_UNIT_TESTS" cannot be used (no authentication provided).
CORAL/Services/ConnectionService Info Replica with connection "oracle://cms_orcoff_prep/CMS_COND_UNIT_TESTS" is invalid and will be skipped.
CORAL/Services/ConnectionService Info SessionHandle for SessionID=2941a512-1c58-11ea-bf2d-fa163e3123de was not open: no need to close it
terminate called after throwing an instance of 'coral::ConnectionNotAvailableException'
  what():  Connection on "oracle://cms_orcoff_prep/CMS_COND_UNIT_TESTS" cannot be established ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )

---> test testCoralSQLPrinting had ERRORS

Looks unrelated to this PR.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[fabiocos]

merge