PPS: configurable timing-tracking cut #28621
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28621/13147
|
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: RecoCTPPS/ProtonReconstruction @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR allows to configure (in python) the cuts for association between timing-RP and tracking-RP local tracks. Previously, these cuts were effectively hard-coded. This is a follow up of an observation presented e.g. in Proton POG meeting 26 Nov 2019 (slide 5), showing that the current cuts a little too strict. In order to maintain the backward compatibility, this PR keeps the default cut values as before.
PR validation:
The plot below compares proton reconstruction results for different periods (rows) and different CMSSW versions/settiings (colours). Comparing blue (before this PR) with red dashed (this PR, default cuts) shows that there is no difference in results. Comparing red dashed (default cuts) with green (enlarged cuts) shows that more reco-proton objects include non-zero number of timing-RP tracks.