New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global declarations in classes.h in L1TNtuples #28692
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28692/13268
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The declaration of a variable of a given type is no longer necessary to generate a ROOT dictionary. This was found by the static analyzer.
db3e6bf
to
3434109
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28692/13270
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: L1Trigger/L1TNtuples @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
ping |
+1 |
merge |
PR description:
The declaration of a variable of a given type is no longer necessary to generate a ROOT dictionary.
This was found by the static analyzer.
PR validation:
The code compiles and the resultant .rootmap file is identical to the original.