restore class definition using PF information #2872
Conversation
|
A new Pull Request was created by @beaudett (Florian Beaudette) for CMSSW_7_1_X. restore class definition using PF information It involves the following packages: RecoEgamma/EgammaElectronAlgos @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
|
Thanks - I'll run some single particle MC... |
| { | ||
| ele->setSuperClusterFbrem(0) ; | ||
| ele->setPfSuperClusterFbrem(0); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you please clarify: this method is now marked as obsolete but you still make changes and keep it in the code...
There was a problem hiding this comment.
I'm referring to
- void addPflowInfo() ;
- void addPflowInfo() ; // now deprecated
There was a problem hiding this comment.
Hello,
as far as I understand, we still want to be able to run the electron reconstruction code in the "oldEgamma" mode, as done in 700pre11 (or pre12). Removing this method will break it this possibility. I added a comment to keep track that we want to drop it eventually.
F.
There was a problem hiding this comment.
Yes, for now we should keep it around so long as we want the option to run
in OldEG mode.
-L
On Sat, Mar 15, 2014 at 10:48 PM, Florian Beaudette <
notifications@github.com> wrote:
In RecoEgamma/EgammaElectronAlgos/src/GsfElectronAlgo.cc:
else
{ ele->setSuperClusterFbrem(0) ; }{- ele->setSuperClusterFbrem(0) ;
- ele->setPfSuperClusterFbrem(0);
}Hello,
as far as I understand, we still want to be able to run the electron
reconstruction code in the "oldEgamma" mode, as done in 700pre11 (or
pre12). Removing this method will break it this possibility. I added a
comment to keep track that we want to drop it eventually.
F.Reply to this email directly or view it on GitHubhttps://github.com//pull/2872/files#r10636835
.
|
Tested on the mix of single particles and TTbar, QCD workflows and observed very few bin-to-bin migrations (apart from the electron category change). Probably a result of the small difference due to training before the fix. |
|
+1 |
RecoEgamma/EgammaElectronAlgos -- restore class definition using PF information
Restore the so-called "Bad-track" class which disappeared during the migration to GED. The electrons which end up in this category were previously in the "showering class".
The plots below have been made with RelValZEE 710pre3 samples.
The migration from one class to the other can be seen here:
(red is new, blue is default 710pre3; the entries <10 are in the barrel; >=10 in the endcaps)
Even though the regression is using the class and was trained before the fix, it seems that it won't be necessary to retrain it.
The resolution is actually slightly improved. The statistics have decreased between the two cases, which is normal.
There are no validation plots for the "badTrack" class, but the inclusive plots is essentially unchanged.
