String returned by value must be stored #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_X. String returned by value must be stored It involves the following packages: CommonTools/Utils @nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks. |
|
Bypassing reco and analysis. Shout if not ok. |
ktf
added a commit
that referenced
this pull request
Mar 17, 2014
Valgrind fix -- String returned by value must be stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a valgrind error discovered by Vincenzo Innocente. The function TypeWithDict::name() returns a string by value. A caller of this function, the free function typeCode(), saved the value of the char* to the embedded C string without saving the string itself. In those cases where TypeWithDict returns a temporary (as it will when the type is a pointer), the stored char* gets used after the temporary string is reclaimed. The fault is in the caller. This pull request has the caller save the returned string on the stack so that it does not get prematurely reclaimed.
This problem was introduced in 7_0_X. A separate pull request will be issued for 7_0_X.