Rename candidate GTs to use official names and update alcareco trigger bits #28804

christopheralanwest · 2020-01-28T05:30:03Z

PR description:

PR #28762 was accidentally approved and merged prior to renaming the GTs to follow the usual convention for official GTs. The string "Candidate" indicates a test GT, which could cause confusion, so this PR simply renames the global tags. The GT diffs below demonstrate that there is no change to the tag content to any of the GTs.

PR validation:

A technical test was performed: runTheMatrix.py -l limited,7.2,7.22 --ibeos

if this PR is a backport please specify the original PR:

This PR is not a backport and should not be backported.

cmsbuild · 2020-01-28T05:30:28Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-28T05:39:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28804/13504

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update phase-2 GT to D49 geometry #28794

cmsbuild · 2020-01-28T05:39:47Z

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2020-01-28T05:40:08Z

please test workflow 7.2,7.22

cmsbuild · 2020-01-28T05:40:09Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 7.2,7.22
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4374/console Started: 2020/01/28 07:17

mmusich · 2020-01-28T08:29:11Z

@christopheralanwest thanks for this PR.
On a related topic, after #28762 was merged I noticed that wf 136.891 is starting to fail with message:

----- Begin Fatal Exception 28-Jan-2020 08:38:22 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  Event run: 320822 lumi: 75 event: 126696592 stream: 1
   [1] Running path 'pathALCARECOSiPixelCalSingleMuon'
   [2] Calling method for module HLTHighLevel/'ALCARECOSiPixelCalSingleMuonHLTFilter'
Exception Message:
 HLTHighLevel [instance: ALCARECOSiPixelCalSingleMuonHLTFilter - path: pathALCARECOSiPixelCalSingleMuon]: No triggerList with key SiPixelCalSingleMuon in AlCaRecoTriggerBitsRcd
----- End Fatal Exception -------------------------------------------------

(see e.g. log here).
This means that the autoCond key run2_data_promptlike which is employed in that wf needs to be updated. As you are touching autoCond here, would it be possible to include a fix for that?
Now as far as I can see the current Global Tag for that key uses the tag AlCaRecoHLTpaths_2017_v5 which is different from the one used by the run3_data_promptlike key (i.e. AlCaRecoHLTpaths8e29_5e33_v7_prompt) which is also contained in the current Prompt Reco GT. I am wondering if this difference is intentional. If it is I can provide a new tag AlCaRecoHLTpaths_2017_v6 with the new trigger keys, otherwise I would think it is advisable to align the two Global Tags to use the same tag.
Please let me know.
cc:
@silviodonato

silviodonato · 2020-01-28T08:30:29Z

please test workflow 136.891

cmsbuild · 2020-01-28T08:30:56Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 136.891
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4376/console Started: 2020/01/28 09:35

silviodonato · 2020-01-28T08:31:23Z

please have a look at #28762 (comment)

cmsbuild · 2020-01-28T10:00:28Z

-1

Tested at: 3d9e2b6

CMSSW: CMSSW_11_1_X_2020-01-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc432/4376/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.891 step3

runTheMatrix-results/136.891_RunSingleMu2018D+RunSingleMu2018D+HLTDR2_2018+RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi+HARVEST2018_L1TMuDQM_Prompt/step3_RunSingleMu2018D+RunSingleMu2018D+HLTDR2_2018+RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi+HARVEST2018_L1TMuDQM_Prompt.log

cmsbuild · 2020-01-28T10:00:31Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-01-28T17:21:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-28T17:28:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28804/13519

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update phase-2 GT to D49 geometry #28794

christopheralanwest · 2020-01-28T17:28:20Z

please test workflow 136.891

cmsbuild · 2020-01-28T17:28:36Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 136.891
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4390/console Started: 2020/01/28 18:33

cmsbuild · 2020-01-28T17:28:38Z

Pull request #28804 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

cmsbuild · 2020-01-28T19:02:06Z

+1
Tested at: bcd63b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc432/4390/summary.html
CMSSW: CMSSW_11_1_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-28T19:02:09Z

Comparison job queued.

cmsbuild · 2020-01-28T20:32:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc432/4390/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-1fc432/136.891_RunSingleMu2018D+RunSingleMu2018D+HLTDR2_2018+RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi+HARVEST2018_L1TMuDQM_Prompt

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697090
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696743
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

christopheralanwest · 2020-01-28T21:18:55Z

+1

cmsbuild · 2020-01-28T21:19:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-01-29T08:27:06Z

+1
thanks for the fix

mmusich · 2020-01-29T14:36:53Z

@christopheralanwest @silviodonato
as far as I can this PR destroys more workflow than the previous situation: https://cms-sw.github.io/relvalLogDetail.html#slc7_amd64_gcc820;CMSSW_11_1_X_2020-01-29-1100
I think I understand why the prompt-like workflows had employed a different trigger bit selection. Certain alcas are run on demand and do not subsist on all the IOVs in Prompt Reco, while they are run over across the board in the IB tests.
I'll provide shortly a new tag AlCaRecoHLTpaths_2017_v6 to be used instead.

mmusich · 2020-01-29T15:20:08Z

the new tag is available: https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/tags/AlCaRecoHLTpaths_2017_v6
Here is the diff w.r.t the previous tag:

Rename candidate GTs to use official names

3d9e2b6

cmsbuild added this to the CMSSW_11_1_X milestone Jan 28, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jan 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 28, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2020

cmsbuild added tests-pending and removed tests-started labels Jan 28, 2020

mmusich mentioned this pull request Jan 28, 2020

update eventSetupPathsKey for Strip/Pixel AlCas #28762

Merged

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2020

cmsbuild removed comparison-pending tests-started labels Jan 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 28, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 28, 2020

christopheralanwest changed the title ~~Rename candidate GTs to use official names~~ Rename candidate GTs to use official names and update alcareco trigger bits Jan 28, 2020

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jan 28, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 29, 2020

cmsbuild merged commit cf33acd into cms-sw:master Jan 29, 2020

christopheralanwest mentioned this pull request Jan 29, 2020

Convert workflows that use pp prompt-like GTs to use offline GTs #28825

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename candidate GTs to use official names and update alcareco trigger bits #28804

Rename candidate GTs to use official names and update alcareco trigger bits #28804

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 •

edited

mmusich commented Jan 28, 2020

silviodonato commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 •

edited

silviodonato commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 •

edited

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

silviodonato commented Jan 29, 2020

mmusich commented Jan 29, 2020

mmusich commented Jan 29, 2020

Rename candidate GTs to use official names and update alcareco trigger bits #28804

Rename candidate GTs to use official names and update alcareco trigger bits #28804

Conversation

christopheralanwest commented Jan 28, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 • edited

mmusich commented Jan 28, 2020

silviodonato commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 • edited

silviodonato commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 • edited

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

christopheralanwest commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

silviodonato commented Jan 29, 2020

mmusich commented Jan 29, 2020

mmusich commented Jan 29, 2020

cmsbuild commented Jan 28, 2020 •

edited

cmsbuild commented Jan 28, 2020 •

edited

cmsbuild commented Jan 28, 2020 •

edited