Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phi-dependent JEC uncertainties #28864

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

ahinzmann
Copy link
Contributor

PR description:

Fix issue #28860.
This has no impact on any CMS workflow, since JEC uncertainty have never had phi-dependence.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This may have an impact once we introduce corrections for 2018-HEM issue, thus backport down to 10_2 releases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28864/13627

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@santocch
Copy link

santocch commented Feb 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4550/console Started: 2020/02/07 15:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

+1
Tested at: 51d7c62
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac9a3c/4550/summary.html
CMSSW: CMSSW_11_1_X_2020-02-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac9a3c/4550/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

silviodonato commented Feb 10, 2020

This is a obvious fix.
Kind reminder fo
db: @ggovi
analysis: @santocch
(The deadline for CMSSW_11_1_0_pre3 is tomorrow)

@silviodonato
Copy link
Contributor

urgent

@silviodonato
Copy link
Contributor

silviodonato commented Feb 10, 2020

cc: @peruzzim @fgolf

@silviodonato
Copy link
Contributor

bugfix

@silviodonato
Copy link
Contributor

merge
@ggovi @santocch please have a look when you have time (the fix is trivial)

@cmsbuild cmsbuild merged commit 90f5234 into cms-sw:master Feb 10, 2020
@santocch
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants