Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CP5 tune generator fragments for Phase2/Run3 RelVal samples #28880

Closed

Conversation

siddhesh86
Copy link
Contributor

PR includes

  1. Added a few generator fragments (e.g. TTbar, MinBias at 14TeV) with CP5 tune, intended to use for phase2 RelVal production in CMSSW release validation
  2. Added new generator fragments needed for phase2 RelVal production in CMSSW release validation
  3. Added corresponding entries for 1) and 2) in the RelVa submission macros (upgradeWorkflowComponents.py, relval_steps.py)
  4. MatrixInjector.py: wmsplit set to 1 for high PU RelVal submission for recent detector configurations (D35, D49 etc). It is needed to run highPU phase2 workflows smoothly in the computing system.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28880/13655

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@smuzaffar
Copy link
Contributor

@siddhesh86 , can you please resolve the conflit?

@siddhesh86
Copy link
Contributor Author

@smuzaffar, the conflict has been resolved. Thanks.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28880/13687

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @siddhesh86 for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @pgunnell, @efeyazgan, @mkirsano, @chayanit, @zhenhu, @kpedro88, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@efeyazgan, @agrohsje, @alberto-sanchez, @qliphy do we no longer put the tune name in the fragment? This seems potentially confusing to me.

@efeyazgan
Copy link
Contributor

@kpedro88 yes, we should definitely have the tune names in the fragments. @siddhesh86 please update the fragments.

@chayanit
Copy link

@silviodonato I would like to have this PR in 11_1_0_pre3 if possible. I was traveling so didn't join release meeting today, when will you create pre3? @siddhesh86 could you make change soon?

@silviodonato
Copy link
Contributor

urgent

@silviodonato
Copy link
Contributor

@chayanit I will try to include it. It depends on how much time will take the update and review of this PR.

@siddhesh86
Copy link
Contributor Author

@chayanit, @silviodonato, @kpedro88, @efeyazgan:
The suggested corrections in the generator fragments including tune name are implemented and another PR (#28932) is created including these corrections. Please continue/move to the PR28932.
Thank you.

@kpedro88
Copy link
Contributor

please close

@cmsbuild cmsbuild closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants