New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using CP5 tune generator fragments for Phase2/Run3 RelVal samples #28880
Using CP5 tune generator fragments for Phase2/Run3 RelVal samples #28880
Conversation
…MSSW release validation
…ubmission for CMSSW release validation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28880/13655
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@siddhesh86 , can you please resolve the conflit? |
@smuzaffar, the conflict has been resolved. Thanks. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28880/13687
|
A new Pull Request was created by @siddhesh86 for master. It involves the following packages: Configuration/Generator @SiewYan, @pgunnell, @efeyazgan, @mkirsano, @chayanit, @zhenhu, @kpedro88, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@efeyazgan, @agrohsje, @alberto-sanchez, @qliphy do we no longer put the tune name in the fragment? This seems potentially confusing to me. |
@kpedro88 yes, we should definitely have the tune names in the fragments. @siddhesh86 please update the fragments. |
@silviodonato I would like to have this PR in 11_1_0_pre3 if possible. I was traveling so didn't join release meeting today, when will you create pre3? @siddhesh86 could you make change soon? |
urgent |
@chayanit I will try to include it. It depends on how much time will take the update and review of this PR. |
@chayanit, @silviodonato, @kpedro88, @efeyazgan: |
please close |
PR includes