HFNose: fix rechitTools for HGCalCLUEAlgo

[mariadalfonso]

This should solve the memory problem introduced with HFNose 2D clusters
#28772

• add the HF to the list of simClusters (needed since the HFNose will not contains the full hadron shower)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13710

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13710/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13710/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13711

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13711/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13711/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13713

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13713/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28917/13713/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[slava77]

For now I comments the 2D sim clusters part: and re-activate at later stage when the full reconstruction will be in place for the HFnose as well.

It's a bit of an odd approach to break the "sim" (DIGI, formally) side to address the issue in making of reco objects. However, it is apparently acceptable.

[slava77]

+1

for #28917 50b7588

• the update in reco is visually in the part relevant to fix the issue in Memory problem in HGCalCLUEAlgoT #28772 [IIUC, this does not lead to any differences by itself]. Changes come from modifications in the digi step, in SimGeneral/MixingModule/python/caloTruthProducer_cfi.py
• jenkins tests pass and comparisons with the baseline show changes only in the workflow with HFNose enabled and only in the [reduction of] "zero energy" hits.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

please test workflow 23434.1001, 23234.1001

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 23434.1001,23234.1001
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4809/console Started: 2020/02/21 10:34

[cmsbuild]

+1
Tested at: 50b7588
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb1ad4/4809/summary.html
CMSSW: CMSSW_11_1_X_2020-02-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb1ad4/4809/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bb1ad4/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bb1ad4/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694086
• DQMHistoTests: Total failures: 166
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693601
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

+1