-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker Alignment: implement PV resolution analysis in the all-in-one tool #28923
Conversation
…needs single refitter sequence)
…onitoring plots, use C++ native types
…oops, do not use TRandom
The code-checks are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The aim of this PR is to introduce the PV resolution analysis in the standard battery of the Tracker Alignment offline validation checks.
The new analyzer
SplitVertexResolution
is added to theAlignment/OfflineValidation
package. It implements the PV resolution analysis using the "split vertex method". In the current implementation it is fully interlaced in the "all-in-one" validation meta-tool (waiting for a better implementation of the job submission which is currently in the works).PR validation:
Relies on the old and new unit / tests, though private larger scale tests using phase-0 and phase-1 pixel data have been carried out.
Some example plots are collected below:
resolution vs number of tracks
pulls vs number of offline vertices in the event:
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is intended
cc
@connorpa @vbotta