Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker Alignment: implement PV resolution analysis in the all-in-one tool #28923

Merged
merged 43 commits into from
Feb 18, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 11, 2020

PR description:

The aim of this PR is to introduce the PV resolution analysis in the standard battery of the Tracker Alignment offline validation checks.
The new analyzer SplitVertexResolution is added to the Alignment/OfflineValidation package. It implements the PV resolution analysis using the "split vertex method". In the current implementation it is fully interlaced in the "all-in-one" validation meta-tool (waiting for a better implementation of the job submission which is currently in the works).

PR validation:

Relies on the old and new unit / tests, though private larger scale tests using phase-0 and phase-1 pixel data have been carried out.
Some example plots are collected below:

  • resolution vs number of tracks
    VertexResolVsNTracks_2016_QCD_MC_vs_2017_QCD_MC_vs_2016_HLTPhysics_data_vs_2017_JetHT_data

  • pulls vs number of offline vertices in the event:
    VertexPullVsNVertices_2016_QCD_MC_vs_2017_QCD_MC_vs_2016_HLTPhysics_data_vs_2017_JetHT_data

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is intended
cc
@connorpa @vbotta

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28923/13722

  • This PR adds an extra 216KB to repository

  • Found files with invalid states:

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4603/console Started: 2020/02/11 16:34

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 8259a31
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea0535/4603/summary.html
CMSSW: CMSSW_11_1_X_2020-02-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea0535/4603/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694005
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693658
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Feb 18, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 88df9ba into cms-sw:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants