Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct beamspot for 2016 MC + update MC tracker alignment scenario for 2016 pre-VFP era [10_6_X] #28989

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of PR #28624, which changes the default beamspot for 2016 scenarios and updates the tracker APEs for MC of the 2016 pre-VFP era. Commits 5d50378 and
e514a31 are cherry-picked from the PR to master. The 10_6_X branch requires an additional two changes of the beamspot scenario, in commit 662b68c. Finally, the global tags are updated in commit 5ea966a. The changes to the GTs can be understood by comparing the diffs with respect to the previous 10_6_X autoCond GTs or by comparison with those in master.

Comparison with previous 10_6_X GT

2016 design MC
Updated to use ideal beamspot
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_design_v6/106X_mcRun2_design_v7
2016 preVFP pp collision MC
Updated to use 25ns beamspot rather than 50ns beamspot. Update to tracker APEs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_preVFP_v1/106X_mcRun2_asymptotic_preVFP_v3
2016 pp collision MC
Updated to use 25ns beamspot rather than 50ns beamspot.
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_v8/106X_mcRun2_asymptotic_v9
2016 cosmic MC
Updated to use 25ns beamspot rather than 50ns beamspot. Not relevant but change is made to minimize unnecessary differences between cosmic and pp collision GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2cosmics_startup_deco_v5/106X_mcRun2cosmics_startup_deco_v6

Comparison between 10_6_X and master
2016 design MC
Only differences are in tau tags added in 11_0_X and obsolete pixel tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_design_v5/106X_mcRun2_design_v7
2016 preVFP pp collision MC
Only differences are in tau tags added in 11_0_X, addition to AlCaReco bits added in 11_1_X, and obsolete pixel tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_asymptotic_preVFP_v4/106X_mcRun2_asymptotic_preVFP_v3
2016 pp collision MC
Only differences are in tau tags added in 11_0_X, addition to AlCaReco bits added in 11_1_X, and obsolete pixel tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_asymptotic_v7/106X_mcRun2_asymptotic_v9
2016 cosmic MC
Only differences is addition to AlCaReco bits added in 11_1_X
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2cosmics_startup_deco_v6/106X_mcRun2cosmics_startup_deco_v6

PR validation:

Please see description of PR #28624 for details of physics validation. In addition, a technical test was performed: runTheMatrix.py -l limited,7.22 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of PR #28624. The backport corresponds to the configuration that is already in use for the ultra-legacy reprocessing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
TauAnalysis/MCEmbeddingTools

@pgunnell, @civanch, @chayanit, @zhenhu, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @pohsun, @santocch, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

backport #28624

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4757/console Started: 2020/02/18 23:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 5ea966a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af413d/4757/summary.html
CMSSW: CMSSW_10_6_X_2020-02-18-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af413d/4757/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7084 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 24988
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187002
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • backport consistent with changes in master
  • changes in DQM and reco quantities PR integration tests only present in 2016 MC, as expected

@civanch
Copy link
Contributor

civanch commented Feb 20, 2020

+1

@kpedro88
Copy link
Contributor

+upgrade

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

Do you have any objection @chayanit @pgunnell @zhenhu ?

@chayanit
Copy link

+1
sorry I thought I have already signed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa0580f into cms-sw:CMSSW_10_6_X Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants