remove tuple copies #29002
remove tuple copies #29002
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29002/13841
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29002/13842
|
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Geometry/TrackerGeometryBuilder @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@davidlange6 - Can we use a linter to determine the cases? There is a flag in clang which would give a warning if the copy is unavoidable and that sort of change would be futile. |
|
+1 |
|
sure why not? This case was particularly simple - looping over member data inside of a const function.
On Feb 20, 2020, at 7:36 AM, Ianna Osborne <notifications@github.com<mailto:notifications@github.com>> wrote:
@davidlange6<https://github.com/davidlange6> - Can we use a linter to determine the cases? There is a flag in clang which would give a warning if the copy is unavoidable and that sort of change would be futile.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29002?email_source=notifications&email_token=ABGPFQ7NWSBGCM75U7F7S33RDYQGJA5CNFSM4KYADGUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMK5QHQ#issuecomment-588634142>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZGMAJSWDTXS6YTCGTRDYQGJANCNFSM4KYADGUA>.
|
|
@davidlange6 concerning your comment about MTD yes, the issue is partly there (I will fix it), but it looks to me that the affected functions are not used , it was a massive port which needs a cleaning, I am slowly going through it. |
perhaps saves 8% of a hl-lhc premixing job
http://mkortela.web.cern.ch/mkortela/cgi-bin/navigator/premix_d35_1040mtd5/test_06_perf/43
(probably the same issue is in the MTD geometry since they've copied all the tracker code by value)