Disabled (for offline) some ECAL plots based on the trigger emulator.

[tanmaymudholkar]

This emulator is not run offline, so the plots were empty.

PR description:

With this PR, the following ECAL DQM plots, which used to be empty for all offline runs, are no longer saved to the ROOT output:

Ecal(Barrel|Endcap)/*SummaryClient/*TTT* Trigger Primitives Non Single Timing summary
Ecal(Barrel|Endcap)/*SummaryClient/*TTT* Trigger Primitives Timing summary
Ecal(Barrel|Endcap)/*TriggerTowerTask/*TTT* Trigger Primitives Non Single Timing summary

PR validation:

We ran the standard suite of tests:

runTheMatrix.py --nproc=4 --nThreads=10 -l limited -i all --ibeos

and noted that the plots in question are not there in the output files anymore.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29004/13844

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29004/13844/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29004/13844/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29004/13846

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for master.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks
DQMOffline/Ecal

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@argiro, @rociovilar this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4795/console Started: 2020/02/20 08:21

[cmsbuild]

+1
Tested at: cd8c63c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3aaa34/4795/summary.html
CMSSW: CMSSW_11_1_X_2020-02-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3aaa34/4795/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2693885
• DQMHistoTests: Total failures: 54
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693512
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -9028.389 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -162.861 KiB EcalEndcap/EESummaryClient
• DQMHistoSizes: changed ( 1000.0,... ): -132.154 KiB EcalEndcap/EETriggerTowerTask
• DQMHistoSizes: changed ( 1000.0,... ): -66.072 KiB EcalBarrel/EBTriggerTowerTask
• DQMHistoSizes: changed ( 1000.0,... ): -20.952 KiB EcalBarrel/EBSummaryClient
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29004/13863

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #29004 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4815/console Started: 2020/02/21 16:41

[cmsbuild]

+1
Tested at: ce46fff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3aaa34/4815/summary.html
CMSSW: CMSSW_11_1_X_2020-02-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3aaa34/4815/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2693885
• DQMHistoTests: Total failures: 55
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693511
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -9028.389 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -162.861 KiB EcalEndcap/EESummaryClient
• DQMHistoSizes: changed ( 1000.0,... ): -132.154 KiB EcalEndcap/EETriggerTowerTask
• DQMHistoSizes: changed ( 1000.0,... ): -66.072 KiB EcalBarrel/EBTriggerTowerTask
• DQMHistoSizes: changed ( 1000.0,... ): -20.952 KiB EcalBarrel/EBSummaryClient
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1