Run3-sim55 Allow CaloHit to have reference of the saved track #29019
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29019/13868
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29019/13869
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29019/13877
|
|
The tests are being triggered in jenkins. |
|
Pull request #29019 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
+1 |
|
This PR only tries to set the association of track to calo hit. In an earlier PR possibility of storing more SimTracks was made under control of a flag for special studies. This cannot be made a default for standard production
Sent from my Verizon 4G LTE smartphone
…-------- Original message --------
From: Fabio Cossutti <notifications@github.com>
Date: 2/26/20 4:52 AM (GMT-06:00)
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Sunanda Banerjee <Sunanda.Banerjee@cern.ch>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Run3-sim55 Allow CaloHit to have reference of the saved track (#29019)
@bsunanda<https://github.com/bsunanda> @civanch<https://github.com/civanch> for my understanding, what is the expected use of this update? Special studies? In production it would make the output to explode, if we keep all the corresponding tracks, am I correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29019?email_source=notifications&email_token=ABGMZOXLCSZTLAUUOWNMD3TREZCTJA5CNFSM4KZHLFFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM7YCDY#issuecomment-591364367>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOV46A3Y7KASFF5YUYDREZCTJANCNFSM4KZHLFFA>.
|
|
@bsunanda ok, thanks |
PR description:
Allows PCaloHit to have the reference of the saved track ID which creates it
PR validation:
Use standard runTheMatrix for testing
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special