Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly get bin edge info from TH2F in PFClient #2902

Merged
merged 1 commit into from
Mar 17, 2014

Conversation

Dr15Jones
Copy link
Contributor

ROOT 5.34.17 gives an error (which is converted to an exception) if
GetBinLowEdge called directly on a TH2F. The correct way is to call
that method on the result of TH2F::GetXaxis().

ROOT 5.34.17 gives an error (which is converted to an exception) if
GetBinLowEdge called directly on a TH2F. The correct way is to call
that method on the result of TH2F::GetXaxis().
@Dr15Jones
Copy link
Contributor Author

@ktf This is needed to fix many failures in _THREADED. I've test compiled it and ran one failing runTheMatrix (15.0) and everything works fine.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Properly get bin edge info from TH2F in PFClient

It involves the following packages:

DQMOffline/PFTau

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Mar 17, 2014

Merging this seems seems to be safe enough. @deguio complain if not ok.

@Dr15Jones I assume th->GetXaxis() != 0 always, right?

ktf added a commit that referenced this pull request Mar 17, 2014
Multithreading -- Properly get bin edge info from TH2F in PFClient
@ktf ktf merged commit 5dac77a into cms-sw:CMSSW_7_1_X Mar 17, 2014
@Dr15Jones
Copy link
Contributor Author

The line right after it seems to assume that.

@Dr15Jones Dr15Jones deleted the fixBadTH2FcallInPFClient branch March 31, 2014 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants