Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles in some more reco subsystems #29026

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Clean BuildFiles in some more reco subsystems #29026

merged 1 commit into from
Feb 26, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick round of automatic BuildFile.xml cleaning to improve the modularity of CMSSW.

After this one, there is probably only one more PR and then all of the Reco* Build files don't use dependencies anymore which are not included in the source files.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29026/13880

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoBTag/Combined
RecoBTag/PerformanceDB
RecoBTag/TensorFlow
RecoBTau/JetTagComputer
RecoCTPPS/PixelLocal
RecoCTPPS/ProtonReconstruction
RecoCaloTools/Navigation
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/ElectronIdentification
RecoHI/HiMuonAlgos
RecoTauTag/HLTProducers
RecoTauTag/ImpactParameter
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @fwyzard, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @jainshilpi, @argiro, @echapon, @varuns23, @smoortga, @lgray, @yenjie, @ferencek, @mandrenguyen, @forthommel, @yetkinyilmaz, @Sam-Harper, @kurtejung, @rovere, @dgulhan, @riga, @jan-kaspar, @MiheeJo, @jazzitup, @JyothsnaKomaragiri, @mverzett, @sobhatta, @lecriste, @afiqaize, @andrzejnovak this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4845/console Started: 2020/02/24 17:29

@cmsbuild
Copy link
Contributor

+1
Tested at: 5d259a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20d1a2/4845/summary.html
CMSSW: CMSSW_11_1_X_2020-02-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild cmsbuild mentioned this pull request Feb 24, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20d1a2/4845/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2695371
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695050
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2020

+1

for #29026 5d259a4

  • code changes are in line with the PR description and the previous similar PRs
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ea801a4 into cms-sw:master Feb 26, 2020
@guitargeek guitargeek deleted the reco_deps_1 branch February 27, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants