Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tautau polar 5 3 x v2 #2904

Merged
merged 5 commits into from Mar 26, 2014
Merged

Tautau polar 5 3 x v2 #2904

merged 5 commits into from Mar 26, 2014

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Mar 17, 2014

Adding code to compute Z polarization as a function of invariant mass.
Back port of code for TauSpinnerFilter and scripts.
Patch for random number generator in TauSpinnerCMS and removed namespace from header file.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @inugent for CMSSW_5_3_X.

Tautau polar 5 3 x v2

It involves the following packages:

GeneratorInterface/TauolaInterface
Validation/EventGenerator

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vciulli
Copy link
Contributor

vciulli commented Mar 18, 2014

+1
changes in TauolaInterface only affects TauSpinner so it is ok for me
@inugent: on which timescale should we include these changes in a new patch/release? is there any urgency or can we just wait for the first opportunity?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@inugent
Copy link
Contributor Author

inugent commented Mar 18, 2014

Hello,
These changes are request by the tau POG, I would say that we need
them 100% for sure before the March 31 deadline for 5_3_X. Best regards,
Ian

On 3/18/2014 2:29 PM, Vitaliano Ciulli wrote:

+1
changes in TauolaInterface only affects TauSpinner so it is ok for me
@inugent https://github.com/inugent: on which timescale should we
include these changes in a new patch/release? is there any urgency or
can we just wait for the first opportunity?


Reply to this email directly or view it on GitHub
#2904 (comment).

Dr. Ian M. Nugent
III. Physikalisches Institut B
RWTH Aachen, D-52056 Aachen
Tel: +49 241 80-27295
Email: nugent@physik.rwth-aachen.de

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+1

smuzaffar added a commit that referenced this pull request Mar 26, 2014
@smuzaffar smuzaffar merged commit 14b67fc into cms-sw:CMSSW_5_3_X Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants