Fix thread safety issue in HLTBTagPerformanceAnalyzer

[makortel]

PR description:

Make global variables const, move them to anonymous namespace. Fixes workflow 10803.0 that fails in the latest IB (following the merge of #28813)
http://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_X_2020-03-03-1100/pyRelValMatrixLogs/run/10803.0_SingleElectronPt1000+SingleElectronPt1000_pythia8_2018_GenSimFullINPUT+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_SingleElectronPt1000+SingleElectronPt1000_pythia8_2018_GenSimFullINPUT+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

Made jointly with @Dr15Jones.

PR validation:

Workflow 10803.0 runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29082/13969

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

HLTriggerOffline/Btag

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@emilbols, @missirol, @smoortga, @JyothsnaKomaragiri, @mverzett, @ferencek, @andrzejnovak, @mtosi this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test workflow 10803.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 10803.0
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4966/console Started: 2020/03/03 16:22

[cmsbuild]

+1
Tested at: edd1a65
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f810d8/4966/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f810d8/4966/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680373
• DQMHistoTests: Total failures: 40
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680014
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

merge

dqm: @andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml
Please have a look. I merged because I wanted this PR in the night IB and in pre4.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[schneiml]

Thanks @makortel !

Also, seeing the PR test results as of now, which now compare the edm::stream DQM modules running multi-trheaded (in the IB) and single-threaded (in the PR tests), it seems that apart from the well-known LETDC plots, everything reproduces properly (and we should blacklist those 3 ProvInfo MEs). This is much better than I feared!