Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obvious bug in particle boosting - backport of PR #25412 in 9_3_X #29106

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Mar 5, 2020

Backport of #25412 for 2017 MC generation.

Needed to regenerate M(tt)-binned 2017 ttbar samples following issues reported in https://indico.cern.ch/event/891199/contributions/3761256/attachments/1992750/3323265/NTUA_TMGReport_24Feb.pdf

@covarell

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

A new Pull Request was created by @swertz (Sébastien Wertz) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Mar 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5005/console Started: 2020/03/05 13:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

+1
Tested at: bf1918d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87dd5d/5005/summary.html
CMSSW: CMSSW_9_3_X_2020-03-01-0000
SCRAM_ARCH: slc6_amd64_gcc630

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87dd5d/5005/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 196
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624075
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@agrohsje
Copy link

agrohsje commented Mar 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@swertz please add some words in the description explaining why you want this backport

@cmsbuild cmsbuild merged commit fcdb6e2 into cms-sw:CMSSW_9_3_X Mar 6, 2020
@swertz swertz deleted the fixMCpartPairFilt_from-CMSSW_9_3_17 branch March 6, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants