Convert TrackingMonitor to be a DQMEDAnalyzer #29127
Conversation
There is no need to hand reset histograms on Lumi boundaries as the DQMStore now does that automatically for MonitorElements which are marked as per Lumi (which is the case here). -Put TrackAnalyzer in a namespace to avoid 1 definition rule problems.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29127/14037
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/TrackingMonitor @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
prompted by #25090 |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
This change has lead to segmentation faults in the IBs. I'm looking right now to see if I can do an easy fix. |
|
The problems are fixed in #29143 |
PR description:
There is no need to hand reset histograms on Lumi boundaries as the DQMStore now does that automatically for MonitorElements which are marked as per Lumi (which is the case here).
-Put TrackAnalyzer in a namespace to avoid 1 definition rule problems.
PR validation:
The code compiles. A visual inspection of the code did not point out any obvious reason this cannot be a stream module.