Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker alignment: Backport millepede submission to Condor to 10_6_X #29135

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

adewit
Copy link
Contributor

@adewit adewit commented Mar 6, 2020

PR description:

This enables submission of the millepede alignment algorithm to Condor, as well as adding some improvements in file copying to/from eos which is needed for the different steps of the alignment algorithm, as well as failure reporting.

PR validation:

Has already been extensively used, also in CMSSW_10_6_X, to produce the ultra legacy alignment campaigns.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #26774, #27144, and #27492. The condor submission is implemented in #27144, the other two take care of the improvements in file copying and error reporting. Needed to be able to run alignments on samples produced in CMSSW_10_6_X without having to cherry pick the commits every time someone wants to set up a new release area.

cc @vbotta @connorpa

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

A new Pull Request was created by @adewit for CMSSW_10_6_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5043/console Started: 2020/03/06 18:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+1
Tested at: 6e08833
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73cfb7/5043/summary.html
CMSSW: CMSSW_10_6_X_2020-03-06-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73cfb7/5043/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211988
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Mar 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8a7ee75 into cms-sw:CMSSW_10_6_X Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants