Cleanup FastSimulation/Calorimetry dependency on SimG4Core/GFlash

[smuzaffar]

Looks like FastSimulation/Calorimetry does not need/use SimG4Core/GFlash.

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29183/14152

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5135/console Started: 2020/03/11 15:20

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

FastSimulation/Calorimetry

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 0c0e164
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e06a/5135/summary.html
CMSSW: CMSSW_11_1_X_2020-03-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Reduce boost dependence in EcalDigi data formats #29147 @camolezi: Reduce boost dependence in EcalDigi data formats
• [HGCal] Scintillator support for RecHits calibration  #29166 @apsallid: [HGCal] Scintillator support for RecHits calibration
• DQM: Fix dcsRecord input tag in offline for DQMProvInfo #29161 @schneiml: DQM: Fix dcsRecord input tag in offline for DQMProvInfo
• Fix deadlock in MonitorElement::division #29164 @Dr15Jones: Fix deadlock in MonitorElement::division

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e06a/5135/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e06a/5135/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e06a/5135/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680257
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 63.528 KiB( 33 files compared)
• DQMHistoSizes: changed ( 20034.0,... ): 3.976 KiB HGCalHitCalibration/hgcal_photon_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 20034.0,... ): 3.973 KiB HGCalHitCalibration/hgcal_ele_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 20034.0,... ): 3.969 KiB HGCalHitCalibration/hgcal_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 20034.0,... ): 3.965 KiB HGCalHitCalibration/h_EoP_CPene_scint_calib_fraction
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@ssekmen, @lveldere, @civanch, @mdhildreth, @sbein any objection of this cleanup?

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1